Messages in this thread | | | Date | Thu, 16 Mar 2023 11:11:22 -0700 | Subject | Re: [PATCH v3 6/8] platform/x86/intel/ifs: Implement Array BIST test | From | "Joseph, Jithu" <> |
| |
On 3/16/2023 2:59 AM, Hans de Goede wrote:
> > After taking a closer look I do see one unrelated issue with this patch > sysfs.c: run_test_store() does: > > if (!ifsd->loaded) > rc = -EPERM; > else > rc = do_core_test(cpu, dev); > > But AFAICT the loaded check really only applies to the first (intel_ifs_0 device) test type and the > Array BIST test should work fine when loaded is false. > > So I think that the if (!ifsd->loaded) error check should be moved to > ifs_test_core() ? >
It is possible that I misinterpreted your comment in my earlier reply. (Thanks Tony for pointing it out) Yes I think moving the load check into ifs_test_core() is better than doing it in run_test_store()
Jithu
| |