lkml.org 
[lkml]   [2023]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 6/8] platform/x86/intel/ifs: Implement Array BIST test
From


On 3/16/2023 2:59 AM, Hans de Goede wrote:

>>
>> Only one IFS test is allowed at a time. This is done using "ifs_sem" defined in sysfs.c
>
> Ah I see.
>
> After taking a closer look I do see one unrelated issue with this patch
> sysfs.c: run_test_store() does:
>
> if (!ifsd->loaded)
> rc = -EPERM;
> else
> rc = do_core_test(cpu, dev);
>
> But AFAICT the loaded check really only applies to the first (intel_ifs_0 device) test type and the
> Array BIST test should work fine when loaded is false.

This is true, the load check only applies to first test. And the patch (5/8) in this series adds the
check you are suggesting to allow the second test to proceed (as given below)

if (ifsd->ro_info->test_num != IFS_TYPE_ARRAY_BIST && !ifsd->loaded)
rc = -EPERM;
else
rc = do_core_test(cpu, dev);

It is possible that the snippet you pasted above was from an earlier state.


Jithu

\
 
 \ /
  Last update: 2023-03-27 01:04    [W:0.269 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site