| Date | Tue, 14 Mar 2023 15:12:27 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH v3 21/38] parport: PC style parport depends on HAS_IOPORT |
| |
On Tue, Mar 14, 2023, at 13:11, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. As PC style parport uses these functions we need to > handle this dependency. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > menuconfig PARPORT > tristate "Parallel port support" > - depends on HAS_IOMEM
I would leave this dependency, or maybe make it 'HAS_IOMEM || HAS_IOPORT'. at least the parport_atari driver uses MMIO instead of PIO.
> help > If you want to use devices connected to your machine's parallel port > (the connector at the computer with 25 holes), e.g. printer, ZIP > @@ -42,7 +41,8 @@ if PARPORT > > config PARPORT_PC > tristate "PC-style hardware" > - depends on ARCH_MIGHT_HAVE_PC_PARPORT || (PCI && !S390) > + depends on ARCH_MIGHT_HAVE_PC_PARPORT > + depends on HAS_IOPORT > help > You should say Y here if you have a PC-style parallel port. All > IBM PC compatible computers and some Alphas have PC-style
This would revert 66bcd06099bb ("parport_pc: Also enable driver for PCI systems"), so I think this is wrong. You can drop the !S390 by adding HAS_IOPORT as a dependency, but the other line should still be
depends on ARCH_MIGHT_HAVE_PC_PARPORT || PCI
Arnd
|