Messages in this thread | | | Date | Thu, 23 Mar 2023 14:53:28 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 15/38] leds: add HAS_IOPORT dependencies |
| |
On Thu, 23 Mar 2023, Niklas Schnelle wrote:
> On Thu, 2023-03-16 at 16:14 +0000, Lee Jones wrote: > > On Tue, 14 Mar 2023, Niklas Schnelle wrote: > > > > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > > not being declared. We thus need to add HAS_IOPORT as dependency for > > > those drivers using them. > > > > > > Acked-by: Pavel Machek <pavel@ucw.cz> > > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > > --- > > > drivers/leds/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks > > Sorry should have maybe been more clear, without patch 1 of this series > this won't work as the HAS_IOPORT config option is new and will be > missing otherwise. There's currently two options of merging this, > either all at once or first only patch 1 and then the additional > patches per subsystem until finally the last patch can remove > inb()/outb() and friends when HAS_IOPORT is unset.
You only sent me this patch.
If there are in-set dependencies, you need to send everyone the whole set so that we can organise a suitable merge strategy between us.
I'll revert the patch for now.
-- Lee Jones [李琼斯]
| |