Messages in this thread | | | From | Jernej Škrabec <> | Subject | Re: [PATCH 12/24] kbuild, soc: sunxi: sram: remove MODULE_LICENSE in non-modules | Date | Tue, 14 Mar 2023 21:39:37 +0100 |
| |
Dne petek, 17. februar 2023 ob 15:10:47 CET je Nick Alcock napisal(a): > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: Samuel Holland <samuel@sholland.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev
Applied, thanks!
Best regards, Jernej
> --- > drivers/soc/sunxi/sunxi_sram.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c > index 92f9186c1c42..21116d47d26d 100644 > --- a/drivers/soc/sunxi/sunxi_sram.c > +++ b/drivers/soc/sunxi/sunxi_sram.c > @@ -421,4 +421,3 @@ builtin_platform_driver_probe(sunxi_sram_driver, > sunxi_sram_probe); > > MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com>"); > MODULE_DESCRIPTION("Allwinner sunXi SRAM Controller Driver"); > -MODULE_LICENSE("GPL");
| |