Messages in this thread Patch in this message | | | Date | Thu, 9 Mar 2023 17:17:41 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 21/24] kbuild, serial: remove MODULE_LICENSE in non-modules |
| |
On Fri, Feb 17, 2023 at 02:10:56PM +0000, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Manivannan Sadhasivam <mani@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jirislaby@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-unisoc@lists.infradead.org > Cc: linux-serial@vger.kernel.org > --- > drivers/tty/serial/rda-uart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/rda-uart.c b/drivers/tty/serial/rda-uart.c > index be5c842b5ba9..c3b29d124759 100644 > --- a/drivers/tty/serial/rda-uart.c > +++ b/drivers/tty/serial/rda-uart.c > @@ -825,4 +825,3 @@ module_exit(rda_uart_exit); > > MODULE_AUTHOR("Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>"); > MODULE_DESCRIPTION("RDA8810PL serial device driver"); > -MODULE_LICENSE("GPL");
No, this should be fine, either force remove all MODULE_* macros from built-in code, or none.
thanks,
greg k-h
| |