Messages in this thread | | | Date | Wed, 1 Mar 2023 14:21:11 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it |
| |
On Sat, 25 Feb 2023, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Lee Jones <lee@kernel.org> > Cc: linux-leds@vger.kernel.org > --- > drivers/leds/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
-- Lee Jones [李琼斯]
| |