Messages in this thread | | | Date | Mon, 27 Feb 2023 12:37:51 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it |
| |
On Sat 2023-02-25 21:39:49, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Dan Murphy <dmurphy@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] | |