Messages in this thread | | | Date | Wed, 1 Mar 2023 20:12:01 -0800 | Subject | [PATCH v1 00/10] Better fixes for grouping of events | From | Ian Rogers <> |
| |
The rules for grouping events has grown more complex. Topdown events must be grouped, but flags like --metric-no-group and flags on metrics don't respect this. Uncore events may be expanded using wild cards for PMU names, but then the events need reordering so the group members are adjacent. Rather than fixing metrics, this change fixes the main event parsing code to first sort and then regroup evsels.
As this is shared functionality changes to it should cause concern. The change is done with the intent of simplifying and making more robust the grouping logic, examples are given. If additional changes are necessary, they are most likely necessary to the evsel__pmu_name logic as the code avoids breaking groups that are on the same PMU. The pmu_name is tweaked in the case of software and aux events, that use groups in a slightly different manner to conventional events.
The code was manually tested as well as passing perf test on a Intel tigerlake CPU with intel-pt.
Ian Rogers (10): libperf evlist: Avoid a use of evsel idx perf stat: Don't remove all grouped events when CPU maps disagree perf record: Early auxtrace initialization before event parsing perf stat: Modify the group test perf evsel: Limit in group test to CPUs perf evsel: Allow const evsel for certain accesses perf evsel: Add function to compute pmu_name perf parse-events: Pass ownership of the group name perf parse-events: Sort and group parsed events perf evsel: Remove use_uncore_alias
tools/lib/perf/evlist.c | 13 +- tools/perf/arch/x86/util/auxtrace.c | 17 +- tools/perf/arch/x86/util/evlist.c | 39 ++--- tools/perf/arch/x86/util/evsel.c | 3 + tools/perf/builtin-record.c | 6 + tools/perf/builtin-stat.c | 24 ++- tools/perf/util/auxtrace.h | 2 + tools/perf/util/evlist.h | 2 +- tools/perf/util/evsel.c | 27 ++- tools/perf/util/evsel.h | 8 +- tools/perf/util/parse-events.c | 253 +++++++++++++--------------- tools/perf/util/parse-events.h | 6 +- tools/perf/util/parse-events.y | 17 +- tools/perf/util/pmu.c | 6 +- tools/perf/util/python.c | 2 +- tools/perf/util/stat-shadow.c | 2 +- 16 files changed, 228 insertions(+), 199 deletions(-)
-- 2.39.2.722.g9855ee24e9-goog
| |