Messages in this thread Patch in this message | | | From | Greg Kroah-Hartman <> | Subject | [PATCH v2] mtd: spi-nor: fix memory leak when using debugfs_lookup() | Date | Wed, 8 Feb 2023 13:57:58 +0100 |
| |
When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time.
Cc: Tudor Ambarus <tudor.ambarus@microchip.com> Cc: Pratyush Yadav <pratyush@kernel.org> Cc: Michael Walle <michael@walle.cc> Cc: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Richard Weinberger <richard@nod.at> Cc: Vignesh Raghavendra <vigneshr@ti.com> Cc: linux-mtd@lists.infradead.org Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- v2: fix up to work when module is removed and added, making the fix much simpler.
drivers/mtd/spi-nor/debugfs.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/debugfs.c b/drivers/mtd/spi-nor/debugfs.c index ff895f6758ea..af41fbc09a97 100644 --- a/drivers/mtd/spi-nor/debugfs.c +++ b/drivers/mtd/spi-nor/debugfs.c @@ -242,6 +242,7 @@ void spi_nor_debugfs_register(struct spi_nor *nor) d = debugfs_create_dir(dev_name(nor->dev), rootdir); nor->debugfs_root = d; + dput(rootdir); debugfs_create_file("params", 0444, d, nor, &spi_nor_params_fops); debugfs_create_file("capabilities", 0444, d, nor, -- 2.39.1
| |