Messages in this thread | | | From | Jiasheng Jiang <> | Subject | Re: [PATCH 1/2] iwl4965: Add missing check for create_singlethread_workqueue | Date | Thu, 9 Feb 2023 09:11:21 +0800 |
| |
On Thu, Feb 09, 2023 at 04:16:58AM +0800, Stanislaw Gruszka wrote: > On Wed, Feb 08, 2023 at 02:30:31PM +0800, Jiasheng Jiang wrote: >> Add the check for the return value of the create_singlethread_workqueue >> in order to avoid NULL pointer dereference. >> >> Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers") >> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > Acked-by: Stanislaw Gruszka <stf_xl@wp.pl> > >> static void >> @@ -6618,7 +6622,11 @@ il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) >> goto out_disable_msi; >> } >> >> - il4965_setup_deferred_work(il); >> + err = il4965_setup_deferred_work(il); >> + if (err) { >> + goto out_free_irq; >> + } > > {} not needded.
I have submitted a v2 removing the "{}" with your Ack.
Thanks, Jiang
| |