Messages in this thread | | | Date | Tue, 7 Feb 2023 21:19:50 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v5 02/23] net: phy: add genphy_c45_read_eee_abilities() function |
| |
On Mon, 6 Feb 2023 14:50:29 +0100 Oleksij Rempel wrote: > +/** > + * mii_eee_cap1_mod_linkmode_t
A bit odd formatting - for a function it should have () at the end?
> + * @adv: target the linkmode advertisement settings > + * @val: register value > + * > + * A function that translates value of following registers to the linkmode: > + * IEEE 802.3-2018 45.2.3.10 "EEE control and capability 1" register (3.20) > + * IEEE 802.3-2018 45.2.7.13 "EEE advertisement 1" register (7.60) > + * IEEE 802.3-2018 45.2.7.14 "EEE "link partner ability 1 register (7.61) > + */ > +static inline void mii_eee_cap1_mod_linkmode_t(unsigned long *adv, u32 val) > +{
> @@ -676,6 +678,8 @@ struct phy_device { > __ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising); > /* used with phy_speed_down */ > __ETHTOOL_DECLARE_LINK_MODE_MASK(adv_old); > + /* used for eee validation */ > + __ETHTOOL_DECLARE_LINK_MODE_MASK(supported_eee);
missing kdoc for the new field
| |