| Date | Tue, 7 Feb 2023 01:44:28 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v5 02/23] net: phy: add genphy_c45_read_eee_abilities() function |
| |
> + /* The 802.3 2018 standard says the top 2 bits are reserved and should > + * read as 0. Also, it seems unlikely anybody will build a PHY which > + * supports 100GBASE-R deep sleep all the way down to 100BASE-TX EEE. > + * If MDIO_PCS_EEE_ABLE is 0xffff assume EEE is not supported. > + */ > + if (val == GENMASK(15, 0)) > + return 0;
Given the comment says 0xffff i would just use 0xffff, not GENMASK.
Other than that:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
|