lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v5 02/23] net: phy: add genphy_c45_read_eee_abilities() function
> +	/* The 802.3 2018 standard says the top 2 bits are reserved and should
> + * read as 0. Also, it seems unlikely anybody will build a PHY which
> + * supports 100GBASE-R deep sleep all the way down to 100BASE-TX EEE.
> + * If MDIO_PCS_EEE_ABLE is 0xffff assume EEE is not supported.
> + */
> + if (val == GENMASK(15, 0))
> + return 0;

Given the comment says 0xffff i would just use 0xffff, not GENMASK.

Other than that:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew

\
 
 \ /
  Last update: 2023-03-27 00:11    [W:0.142 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site