Messages in this thread Patch in this message | | | Date | Mon, 6 Feb 2023 12:23:19 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH V3 3/3] perf test: Support the retire_lat check |
| |
Em Mon, Feb 06, 2023 at 12:01:44PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Feb 02, 2023 at 11:22:09AM -0800, kan.liang@linux.intel.com escreveu: > > From: Kan Liang <kan.liang@linux.intel.com> > > > > Add test for the new field for Retire Latency in the X86 specific test. > > Is this passing 'perf test' for you? > > [root@quaco ~]# perf test -v "x86 sample parsing" > 74: x86 Sample parsing : > --- start --- > test child forked, pid 72526 > Samples differ at 'retire_lat' > parsing failed for sample_type 0x1000000 > test child finished with -1 > ---- end ---- > x86 Sample parsing: FAILED! > [root@quaco ~]#
In tools/perf/arch/x86/util/event.c you have:
void arch_perf_parse_sample_weight(struct perf_sample *data, const __u64 *array, u64 type) { union perf_sample_weight weight;
weight.full = *array; if (type & PERF_SAMPLE_WEIGHT) data->weight = weight.full; else { data->weight = weight.var1_dw; data->ins_lat = weight.var2_w; data->retire_lat = weight.var3_w; } }
void arch_perf_synthesize_sample_weight(const struct perf_sample *data, __u64 *array, u64 type) { *array = data->weight;
if (type & PERF_SAMPLE_WEIGHT_STRUCT) { *array &= 0xffffffff; *array |= ((u64)data->ins_lat << 32); } }
didn't you forget to encode data->retire_lat at arch_perf_synthesize_sample_weight()?
- Arnaldo
> > Signed-off-by: Kan Liang <kan.liang@linux.intel.com> > > --- > > > > New patch since V2 > > > > tools/perf/arch/x86/tests/sample-parsing.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/arch/x86/tests/sample-parsing.c b/tools/perf/arch/x86/tests/sample-parsing.c > > index 690c7c07e90d..a061e8619267 100644 > > --- a/tools/perf/arch/x86/tests/sample-parsing.c > > +++ b/tools/perf/arch/x86/tests/sample-parsing.c > > @@ -27,8 +27,10 @@ static bool samples_same(const struct perf_sample *s1, > > const struct perf_sample *s2, > > u64 type) > > { > > - if (type & PERF_SAMPLE_WEIGHT_STRUCT) > > + if (type & PERF_SAMPLE_WEIGHT_STRUCT) { > > COMP(ins_lat); > > + COMP(retire_lat); > > + } > > > > return true; > > } > > @@ -48,6 +50,7 @@ static int do_test(u64 sample_type) > > struct perf_sample sample = { > > .weight = 101, > > .ins_lat = 102, > > + .retire_lat = 103, > > }; > > struct perf_sample sample_out; > > size_t i, sz, bufsz; > > -- > > 2.35.1 > > > > -- > > - Arnaldo
--
- Arnaldo
| |