Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 6 Feb 2023 12:54:02 +0100 | Subject | Re: [PATCH] checkpatch.pl: Relax commit ID check to allow more than 12 chars |
| |
Hi Joe,
On Mon, Feb 6, 2023 at 12:09 PM Joe Perches <joe@perches.com> wrote: > On Mon, 2023-02-06 at 09:38 +0100, Geert Uytterhoeven wrote: > > On Sat, Feb 4, 2023 at 5:59 PM Joe Perches <joe@perches.com> wrote: > > > On Sun, 2023-01-29 at 09:52 -0800, Joe Perches wrote: > > > > On Sun, 2023-01-29 at 13:34 +0100, Jonathan Neuschäfer wrote: > > > > > By now, `git log --pretty=%h` (on my copy of linux.git) prints commit > > > > > hashes with 13 digits, because of the number of objects. > > > > > > > > > > Relax the rule in checkpatch.pl to allow a few more digits (up to 16). > > > > > > > > NAK without updating the process docs first. > > > > > > btw: it looks like 12 will still be sufficient for awhile yet > > > > > > $ git count > > > total 1154908 > > > > Hmm, Ubuntu git too old? > > Don't think so > > $ git --version > git version 2.39.1
Exactly, Ubuntu 22.04LTS only has
$ git --version git version 2.34.1
i.e. no git count.
> > I've been using core.abbrev=16 for a while, and some maintainers > > reject my patches with Fixes: tags because of that... > > Perhaps because that's not the documented format?
Right. I look a lot at history, and don't want to become slowed down by ambiguous Fixes: tags anytime soon (or later).
> > Is it really worthwhile to save on the number of hexits, making lookup > > of some commits more inconvenient? > > > > Note that while "git show edb9b8" suggests edb9b8f[...], > > gitweb says bad object id: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=edb9b8 > > hmm. Not here. > > $ git show edb9b8 > tree edb9b8
Yeah, I also have that tree object. But I don't want to see the tree object; I want to see the commit object, which is in v6.2-rc7: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=edb9b8f
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |