Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 6 Feb 2023 09:38:59 +0100 | Subject | Re: [PATCH] checkpatch.pl: Relax commit ID check to allow more than 12 chars |
| |
Hi Joe,
On Sat, Feb 4, 2023 at 5:59 PM Joe Perches <joe@perches.com> wrote: > On Sun, 2023-01-29 at 09:52 -0800, Joe Perches wrote: > > On Sun, 2023-01-29 at 13:34 +0100, Jonathan Neuschäfer wrote: > > > By now, `git log --pretty=%h` (on my copy of linux.git) prints commit > > > hashes with 13 digits, because of the number of objects. > > > > > > Relax the rule in checkpatch.pl to allow a few more digits (up to 16). > > > > NAK without updating the process docs first. > > btw: it looks like 12 will still be sufficient for awhile yet > > $ git count > total 1154908
Hmm, Ubuntu git too old?
> $ git -c core.abbrev=5 log --pretty=format:%h | \ > perl -nE 'chomp;say length' | sort | uniq -c | sort -n -k2 > 198 5 > 664613 6 > 450955 7 > 36667 8 > 2312 9 > 155 10 > 8 11
I'm already at twelve:
433752 6 640819 7 62759 8 3998 9 261 10 12 11 1 12
I've been using core.abbrev=16 for a while, and some maintainers reject my patches with Fixes: tags because of that...
Is it really worthwhile to save on the number of hexits, making lookup of some commits more inconvenient?
Note that while "git show edb9b8" suggests edb9b8f[...], gitweb says bad object id: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=edb9b8
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |