lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 15/18] media: venus: Remap bufreq fields on HFI6XX
From
On 28/02/2023 15:24, Konrad Dybcio wrote:
> Similarly to HFI4XX, the fields are remapped on 6XX as well. Fix it.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/media/platform/qcom/venus/hfi_helper.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h
> index d2d6719a2ba4..8d683a6e07af 100644
> --- a/drivers/media/platform/qcom/venus/hfi_helper.h
> +++ b/drivers/media/platform/qcom/venus/hfi_helper.h
> @@ -1152,11 +1152,14 @@ struct hfi_buffer_display_hold_count_actual {
>
> /* HFI 4XX reorder the fields, use these macros */
> #define HFI_BUFREQ_HOLD_COUNT(bufreq, ver) \
> - ((ver) == HFI_VERSION_4XX ? 0 : (bufreq)->hold_count)
> + ((ver) == HFI_VERSION_4XX || (ver) == HFI_VERSION_6XX \
> + ? 0 : (bufreq)->hold_count)
> #define HFI_BUFREQ_COUNT_MIN(bufreq, ver) \
> - ((ver) == HFI_VERSION_4XX ? (bufreq)->hold_count : (bufreq)->count_min)
> + ((ver) == HFI_VERSION_4XX || (ver) == HFI_VERSION_6XX \
> + ? (bufreq)->hold_count : (bufreq)->count_min)
> #define HFI_BUFREQ_COUNT_MIN_HOST(bufreq, ver) \
> - ((ver) == HFI_VERSION_4XX ? (bufreq)->count_min : 0)
> + ((ver) == HFI_VERSION_4XX || (ver) == HFI_VERSION_6XX \
> + ? (bufreq)->count_min : 0)
>
> struct hfi_buffer_requirements {
> u32 type;
>

Doesn't this need a Fixes ?

---
bod

\
 
 \ /
  Last update: 2023-03-27 00:38    [W:0.286 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site