Messages in this thread | | | Date | Tue, 28 Feb 2023 17:08:59 +0100 | Subject | Re: [PATCH 12/18] media: venus: firmware: Correct IS_V6() checks | From | Konrad Dybcio <> |
| |
On 28.02.2023 16:48, Bryan O'Donoghue wrote: > On 28/02/2023 15:24, Konrad Dybcio wrote: >> - if (IS_V6(core)) >> + /* >> + * This may sound counter-intuitive, but when there's no TZ, we gotta >> + * do things that it would otherwise do for us, such as initializing >> + * the hardware at a very basic level. >> + * */ > > Suggest "When there is no TZ we have got to initialize hardware in-lieu of TZ" as an example. > > Either way please drop that "gotta" - I ain't gonna ACK such a butchering of the language. Gotta do what you gotta do.. :P I can reword it.
Konrad > > Then > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
| |