Messages in this thread | | | Date | Tue, 28 Feb 2023 20:47:43 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [PATCH] m68k: mm: Move initrd phys_to_virt handling after paging_init() |
| |
On Tue, 28 Feb 2023, Geert Uytterhoeven wrote:
> On Mon, Feb 27, 2023 at 11:46 PM Finn Thain <fthain@linux-m68k.org> wrote: > > On Mon, 27 Feb 2023, Geert Uytterhoeven wrote: > > > When booting with an initial ramdisk on platforms where physical memory > > > does not start at address zero (e.g. on Amiga): > > > > > > initrd: 0ef0602c - 0f800000 > > > Zone ranges: > > > DMA [mem 0x0000000008000000-0x000000f7ffffffff] > > > Normal empty > > > Movable zone start for each node > > > Early memory node ranges > > > node 0: [mem 0x0000000008000000-0x000000000f7fffff] > > > Initmem setup node 0 [mem 0x0000000008000000-0x000000000f7fffff] > > > Unable to handle kernel access at virtual address (ptrval) > > > Oops: 00000000 > > > Modules linked in: > > > PC: [<00201d3c>] memcmp+0x28/0x56 > > > > > > As phys_to_virt() relies on m68k_memoffset and module_fixup(), it must > > > not be called before paging_init(). Hence postpone the phys_to_virt > > > handling for the initial ramdisk until after calling paging_init(). > > > > Thanks for debugging this issue. > > Np, you're welcome. > > > > While at it, reduce #ifdef clutter by using IS_ENABLED() instead. > > > > > > Fixes: 376e3fdecb0dcae2 ("m68k: Enable memtest functionality") > > > > I apologise for the trouble caused by that patch. > > Does that count as an Acked-by? ;-) >
Well, git log | grep suggested Mea-culpa-by and some others...
Acked-by: Finn Thain <fthain@linux-m68k.org>
| |