lkml.org 
[lkml]   [2023]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] m68k: mm: Move initrd phys_to_virt handling after paging_init()
On Mon, 27 Feb 2023, Geert Uytterhoeven wrote:

> When booting with an initial ramdisk on platforms where physical memory
> does not start at address zero (e.g. on Amiga):
>
> initrd: 0ef0602c - 0f800000
> Zone ranges:
> DMA [mem 0x0000000008000000-0x000000f7ffffffff]
> Normal empty
> Movable zone start for each node
> Early memory node ranges
> node 0: [mem 0x0000000008000000-0x000000000f7fffff]
> Initmem setup node 0 [mem 0x0000000008000000-0x000000000f7fffff]
> Unable to handle kernel access at virtual address (ptrval)
> Oops: 00000000
> Modules linked in:
> PC: [<00201d3c>] memcmp+0x28/0x56
>
> As phys_to_virt() relies on m68k_memoffset and module_fixup(), it must
> not be called before paging_init(). Hence postpone the phys_to_virt
> handling for the initial ramdisk until after calling paging_init().
>

Thanks for debugging this issue.

> While at it, reduce #ifdef clutter by using IS_ENABLED() instead.
>
> Fixes: 376e3fdecb0dcae2 ("m68k: Enable memtest functionality")

I apologise for the trouble caused by that patch.

\
 
 \ /
  Last update: 2023-03-27 00:37    [W:1.485 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site