lkml.org 
[lkml]   [2023]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] gpio: mxc: use dynamic allocation of base
Date
Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using static
gpiobase allocation"), one or more warnings are printed during boot on
systems where static allocation of GPIO base is used:

[ 1.611480] gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 1.622893] gpio gpiochip1: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 1.633272] gpio gpiochip2: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 1.643388] gpio gpiochip3: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 1.653474] gpio gpiochip4: Static allocation of GPIO base is deprecated, use dynamic allocation.

So let's follow the suggestion and use dynamic allocation.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

drivers/gpio/gpio-mxc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 9d0cec4b82a3..abc129a88a62 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -462,8 +462,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
port->gc.request = gpiochip_generic_request;
port->gc.free = gpiochip_generic_free;
port->gc.to_irq = mxc_gpio_to_irq;
- port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :
- pdev->id * 32;
+ port->gc.base = -1;

err = devm_gpiochip_add_data(&pdev->dev, &port->gc, port);
if (err)
--
2.32.0
\
 
 \ /
  Last update: 2023-03-27 00:36    [W:0.066 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site