lkml.org 
[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/2] arch/*/io.h: remove ioremap_uc in some architectures
On 02/21/23 at 11:03am, Geert Uytterhoeven wrote:
> Hi Baoquan,
>
> Thanks for your patch!
>
> On Tue, Feb 21, 2023 at 7:36 AM Baoquan He <bhe@redhat.com> wrote:
> > ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> > extension, and on ia64 with its slightly unconventional ioremap()
> > behavior, everywhere else this is the same as ioremap() anyway.
> >
> > So here, remove the ioremap_uc() definition in architecutures other
> > than x86 and ia64. These architectures all have asm-generic/io.h
> > included and will have the default ioremap_uc() definition which
> > returns NULL. If any ARCH really needs a specific ioremap_uc() for
>
> Please make it very clear that this changes existing behavior.
> At first, I had completely missed that.

Sure, I will update log.

>
> And of course the documentation should be updated to reflect that.

Makes sense, will do.

>
> > its own usage, one ioremap_uc() can be added in the ARH.
>
> s/ARH/ARCH/

Will update.

>
> > arch/m68k/include/asm/kmap.h | 1 -
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks for reviewing.

\
 
 \ /
  Last update: 2023-03-27 00:30    [W:0.050 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site