[lkml]   [2023]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 2/2] arch/*/io.h: remove ioremap_uc in some architectures
Hi Baoquan,

Thanks for your patch!

On Tue, Feb 21, 2023 at 7:36 AM Baoquan He <> wrote:
> ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> extension, and on ia64 with its slightly unconventional ioremap()
> behavior, everywhere else this is the same as ioremap() anyway.
> So here, remove the ioremap_uc() definition in architecutures other
> than x86 and ia64. These architectures all have asm-generic/io.h
> included and will have the default ioremap_uc() definition which
> returns NULL. If any ARCH really needs a specific ioremap_uc() for

Please make it very clear that this changes existing behavior.
At first, I had completely missed that.

And of course the documentation should be updated to reflect that.

> its own usage, one ioremap_uc() can be added in the ARH.


> arch/m68k/include/asm/kmap.h | 1 -

Acked-by: Geert Uytterhoeven <>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

 \ /
  Last update: 2023-03-27 00:29    [W:0.885 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site