Messages in this thread | | | From | Leo Li <> | Subject | RE: [PATCH] net: phy: at803x: fix the wol setting functions | Date | Tue, 21 Feb 2023 23:02:18 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Tuesday, February 21, 2023 4:57 PM > To: Leo Li <leoyang.li@nxp.com> > Cc: Heiner Kallweit <hkallweit1@gmail.com>; Russell King > <linux@armlinux.org.uk>; David S . Miller <davem@davemloft.net>; Jakub > Kicinski <kuba@kernel.org>; Luo Jie <luoj@codeaurora.org>; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Viorel Suman > <viorel.suman@nxp.com>; Wei Fang <wei.fang@nxp.com> > Subject: Re: [PATCH] net: phy: at803x: fix the wol setting functions > > On Tue, Feb 21, 2023 at 04:40:31PM -0600, Li Yang wrote: > > In 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"), it > > seems not correct to use a wol_en bit in a 1588 Control Register which > > is only available on AR8031/AR8033(share the same phy_id) to determine > > if WoL is enabled. Change it back to use AT803X_INTR_ENABLE_WOL for > > determining the WoL status which is applicable on all chips supporting > > wol. Also update the at803x_set_wol() function to only update the 1588 > > register on chips having it. > > > After this change, disabling wol at probe from d7cd5e06c9dd ("net: > > phy: at803x: disable WOL at probe") is no longer needed. So it is > > removed. > > Rather than remove it, please git revert it, and explain in the commit > message why.
Not all changes from that patch is removed. The remaining part might still be useful.
> > > > > Also remove the set_wol()/get_wol() callbacks from AR8032 which > > doesn't support WoL. > > This change was part of 5800091a2061 ("net: phy: at803x: add support for > AR8032 PHY") > > Please break this patch up into individual fixes. The different fixes might > need different levels of backporting etc.
Ok. I can split this out.
Regards, Leo
| |