lkml.org 
[lkml]   [2023]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v1 1/1] usb: gadget: configfs: Use memcpy_and_pad()
Date
Instead of zeroing some memory and then copying data in part or all of it,
use memcpy_and_pad().
This avoids writing some memory twice and should save a few cycles.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/usb/gadget/configfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index 1346b330b358..0ee47e4c22cb 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -909,8 +909,7 @@ static ssize_t webusb_landingPage_store(struct config_item *item, const char *pa

mutex_lock(&gi->lock);
// ensure 0 bytes are set, in case the new landing page is shorter then the old one.
- memset(gi->landing_page, 0, sizeof(gi->landing_page));
- memcpy(gi->landing_page, page, l);
+ memcpy_and_pad(gi->landing_page, sizeof(gi->landing_page), page, l, 0);
mutex_unlock(&gi->lock);

return len;
--
2.39.1
\
 
 \ /
  Last update: 2023-03-27 00:07    [W:0.097 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site