Messages in this thread | | | Date | Thu, 02 Feb 2023 10:47:58 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH v3 1/2] net: fec: restore handling of PHY reset line as optional |
| |
On Wed, Feb 1, 2023, at 22:53, Dmitry Torokhov wrote: > Conversion of the driver to gpiod API done in 468ba54bd616 ("fec: > convert to gpio descriptor") incorrectly made reset line mandatory and > resulted in aborting driver probe in cases where reset line was not > specified (note: this way of specifying PHY reset line is actually > deprecated). > > Switch to using devm_gpiod_get_optional() and skip manipulating reset > line if it can not be located. > > Fixes: 468ba54bd616 ("fec: convert to gpio descriptor") > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > > v3: removed handling of 'phy-reset-active-high', it was moved to patch #2 > v2: dropped conversion to generic device properties from the patch
Thanks for fixing it,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |