Messages in this thread | | | Subject | Re: [PATCH] clk: imx: pll14xx: fix recalc_rate for negative kdiv | From | Stephen Boyd <> | Date | Fri, 17 Feb 2023 17:44:04 -0800 |
| |
Quoting Kevin Groeneveld (2022-12-10 12:38:35) > kdiv is a signed 16 bit value in the DEV_CTL1 register. Commit > 53990cf9d5b4 ("clk: imx: pll14xx: consolidate rate calculation") changed > the kdiv variable from a short int to just int. When the value read from > the DIV_CTL1 register is assigned directly to an int the sign of the value > is lost resulting in incorrect results when the value is negative. Adding > a s16 cast to the register value fixes the issue. > > Fixes: 53990cf9d5b4 ("clk: imx: pll14xx: consolidate rate calculation") > Signed-off-by: Kevin Groeneveld <kgroeneveld@lenbrook.com> > ---
Applied to clk-fixes
| |