Messages in this thread | | | From | Ryan Chen <> | Subject | RE: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver | Date | Thu, 16 Feb 2023 09:20:59 +0000 |
| |
Hello Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, February 16, 2023 4:18 AM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew > Jeffery <andrew@aj.id.au>; Philipp Zabel <p.zabel@pengutronix.de>; > openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 > i2C driver > > On 15/02/2023 06:43, Ryan Chen wrote: > >>> + - $ref: /schemas/i2c/i2c-controller.yaml# > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - aspeed,ast2600-i2c > >> > >> NAK. It's already there. Please do not waste our time in submitting > >> duplicated drivers. > > > > It is not duplicated, as my description in cover " This series add AST2600 i2c > new register set driver" > > So, this will be different driver compatible. > > The original compatible is > > - aspeed,ast2400-i2c-bus > > - aspeed,ast2500-i2c-bus > > - aspeed,ast2600-i2c-bus > > So the new register set compatible is "- aspeed,ast2600-i2c", remove "bus". > > Bindings are documenting hardware, so I claim - we already have this > hardware described and this is duplicated. Otherwise - what are these two I2C > controllers and what are the differences? Why they do not have really different > name? Bus looks more like a mistake than a differentiating name. For misunderstanding, or mistaken. I purpose to be aspeed,ast2600-i2cv2, will it more clear way ?
Best regards, Ryan Chen
| |