Messages in this thread | | | Date | Thu, 16 Feb 2023 09:08:51 +0100 | Subject | Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver | From | Krzysztof Kozlowski <> |
| |
On 16/02/2023 05:17, Dhananjay Phadke wrote: > Hi Ryan, > > On 2/14/2023 9:43 PM, Ryan Chen wrote: >> It is not duplicated, as my description in cover " This series add AST2600 i2c new register set driver" >> So, this will be different driver compatible. >> The original compatible is >> - aspeed,ast2400-i2c-bus >> - aspeed,ast2500-i2c-bus >> - aspeed,ast2600-i2c-bus >> So the new register set compatible is "- aspeed,ast2600-i2c", remove "bus". > > Is it possible to keep existing driver drivers/i2c/busses/i2c-aspeed.c > for ast2400/ast2500, while move ast2600 support to new driver > altogether, say i2c-ast2600.c along with new register mode? By default > new driver can support legacy mode with same compatible "aspeed,ast2600- > i2c-bus", additionally driven by dt props, switch to new mode.
So this is for the same hardware? Then the bindings are duplicated. Driver is actually duplicated as well - rework the old one, instead of adding this.
Best regards, Krzysztof
| |