Messages in this thread | | | From | Nathan Lynch <> | Subject | Re: [PATCH v1 1/9] powerpc/machdep: Define 'compatible' property in ppc_md and use it | Date | Wed, 15 Feb 2023 12:44:37 -0600 |
| |
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Most probe functions do nothing else than checking whether > the machine is compatible to a given string. > > Define that string in ppc_md structure and check it directly from > probe_machine() instead of using ppc_md.probe() for that. > > Keep checking in ppc_md.probe() only for more complex probing. > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > v3: New > --- > arch/powerpc/include/asm/machdep.h | 1 + > arch/powerpc/kernel/setup-common.c | 13 +++++++------ > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h > index 378b8d5836a7..c5dfe5ff923c 100644 > --- a/arch/powerpc/include/asm/machdep.h > +++ b/arch/powerpc/include/asm/machdep.h > @@ -20,6 +20,7 @@ struct pci_host_bridge; > > struct machdep_calls { > char *name; > + char *compatible;
Seems like 'compatible' ought to be const char *? Possibly 'name' also. I'm able to build ppc64le with those changes, at least.
| |