Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v1 3/9] powerpc/47x: Split ppc47x machine in two | Date | Thu, 16 Feb 2023 08:58:35 +1100 |
| |
Christophe Leroy <christophe.leroy@csgroup.eu> writes: > This machine matches two compatibles and sets .pci_irq_fixup > on one of them. > > Split it into two machines, then the probe function can be dropped.
That will break the machine initcalls that look for ppc47x:
arch/powerpc/platforms/44x/ppc476.c:machine_device_initcall(ppc47x, ppc47x_device_probe); arch/powerpc/platforms/44x/ppc476.c:machine_arch_initcall(ppc47x, ppc47x_get_board_rev);
It still compiles, because of the weak attribute in machine_is(), but those initcalls will never match and so never run.
cheers
| |