Messages in this thread | | | Date | Wed, 15 Feb 2023 16:34:48 -0500 | Subject | Re: [PATCH] drm/amd/display: only warn once in dce110_edp_wait_for_hpd_ready() | From | Harry Wentland <> |
| |
On 2/14/23 16:12, Hamza Mahfooz wrote: > Since, hot plugging eDP displays isn't supported, it is sufficient for > us to warn about the lack of a connected display once. So, use ASSERT() > in dce110_edp_wait_for_hpd_ready() instead of DC_LOG_WARNING(). > > Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > index fb3fd5b7c78b..0d4d3d586166 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > @@ -779,10 +779,8 @@ void dce110_edp_wait_for_hpd_ready( > > dal_gpio_destroy_irq(&hpd); > > - if (false == edp_hpd_high) { > - DC_LOG_WARNING( > - "%s: wait timed out!\n", __func__); > - } > + /* ensure that the panel is detected */ > + ASSERT(edp_hpd_high > } > > void dce110_edp_power_control(
| |