Messages in this thread | | | From | Christophe Leroy <> | Subject | Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c | Date | Tue, 14 Feb 2023 05:49:24 +0000 |
| |
Le 13/02/2023 à 21:15, Pali Rohár a écrit : > On Monday 13 February 2023 20:05:09 Christophe Leroy wrote: >> Le 24/12/2022 à 22:14, Pali Rohár a écrit : >>> +#ifdef CONFIG_MPC85xx_RDB >>> +static void __init mpc85xx_rdb_pic_init(void) >>> +{ >>> + struct mpic *mpic; >>> + >>> + mpic = mpic_alloc(NULL, 0, >>> + MPIC_BIG_ENDIAN | >>> + MPIC_SINGLE_DEST_CPU, >>> + 0, 256, " OpenPIC "); >> >> Can you make it a single line ? At least no more than two lines ? > > All these lines are already present in kernel tree. > So it could be fixed in separate patch. > > If needed I can do it as part of this series in new patch. >
Well, that goes away in patch 5. So it is not really worth it.
| |