lkml.org 
[lkml]   [2023]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH 1/1] PCI: layerscape: Set 64-bit DMA mask
Date
> >
> > + /* set 64-bit DMA mask and coherent DMA mask */
> > + if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)))
> > + dev_warn(dev, "Failed to set 64-bit DMA mask.\n");
>
> Isn't this mandatory? Why not dev_err_probe and return the error?

I don't think it is mandatory. If failure, dma will use swiotlb.
Just an additional memcpy involved.

Frank Li

>
> --Sean
>
> > platform_set_drvdata(pdev, pcie);
> >
> > ret = dw_pcie_ep_init(&pci->ep);

\
 
 \ /
  Last update: 2023-03-27 00:23    [W:0.057 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site