lkml.org 
[lkml]   [2023]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] PCI: layerscape: Set 64-bit DMA mask
From
On 1/12/23 14:36, Frank Li wrote:
> From: Guanhua Gao <guanhua.gao@nxp.com>
>
> Set DMA mask and coherent DMA mask to enable 64-bit addressing.
>
> Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index 1b884854c18e..c19e7ec58b05 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -261,6 +261,10 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> pcie->max_width = (dw_pcie_readw_dbi(pci, PCIE_LINK_CAP) >>
> MAX_LINK_W_SHIFT) & MAX_LINK_W_MASK;
>
> + /* set 64-bit DMA mask and coherent DMA mask */
> + if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)))
> + dev_warn(dev, "Failed to set 64-bit DMA mask.\n");

Isn't this mandatory? Why not dev_err_probe and return the error?

--Sean

> platform_set_drvdata(pdev, pcie);
>
> ret = dw_pcie_ep_init(&pci->ep);

\
 
 \ /
  Last update: 2023-03-27 00:23    [W:0.098 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site