lkml.org 
[lkml]   [2023]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] fixed typos on selftests/bpf
From
Hi--

On 2/14/23 07:28, Taichi Nishimura wrote:
> I run spell checker and found typos in selftest/bpf/ files.
> Fixed all of the detected typos.
>
> This patch is an extra credit for kselftest task
> in the Linux kernel bug fixing spring unpaid 2023.
>
> Best regards,
> Taichi Nishimura
>
> Signed-off-by: Taichi Nishimura <awkrail01@gmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 2 +-
> tools/testing/selftests/bpf/prog_tests/trampoline_count.c | 2 +-
> tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c | 2 +-
> tools/testing/selftests/bpf/progs/dynptr_fail.c | 2 +-
> tools/testing/selftests/bpf/progs/strobemeta.h | 2 +-
> tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
> tools/testing/selftests/bpf/progs/test_subprogs.c | 2 +-
> tools/testing/selftests/bpf/progs/test_xdp_vlan.c | 2 +-
> tools/testing/selftests/bpf/test_cpp.cpp | 2 +-
> tools/testing/selftests/bpf/veristat.c | 4 ++--
> 10 files changed, 12 insertions(+), 12 deletions(-)
>

Issues here:

> @@ -610,7 +610,7 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
> *
> * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
> *
> - * clang will substitue a costant for sizeof, which allows the verifier
> + * clang will substitute a costant for sizeof, which allows the verifier

constant

> * to track it's value. Based on this, it can figure out the constant

its value.

> * return value, and calling code works while still being "generic" to
> * IPv4 and IPv6.

The other changes look good. Thanks.

After fixing the issues above:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>


--
~Randy

\
 
 \ /
  Last update: 2023-03-27 00:23    [W:0.073 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site