Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH net-next] net: ethernet: mtk_wed: No need to clear memory after a dma_alloc_coherent() call | Date | Sun, 12 Feb 2023 07:51:51 +0100 |
| |
dma_alloc_coherent() already clears the allocated memory, there is no need to explicitly call memset().
Moreover, it is likely that the size in the memset() is incorrect and should be "size * sizeof(*ring->desc)".
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/mediatek/mtk_wed.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c index 95ac4f71d2b2..95d890870984 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -787,7 +787,6 @@ mtk_wed_rro_ring_alloc(struct mtk_wed_device *dev, struct mtk_wed_ring *ring, ring->desc_size = sizeof(*ring->desc); ring->size = size; - memset(ring->desc, 0, size); return 0; } -- 2.34.1
| |