lkml.org 
[lkml]   [2023]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/6] iommu: Add new iommu op to get iommu hardware information
Date
> From: Baolu Lu <baolu.lu@linux.intel.com>
> Sent: Saturday, February 11, 2023 11:43 AM
>
> On 2023/2/10 15:28, Tian, Kevin wrote:
> >> From: Liu, Yi L<yi.l.liu@intel.com>
> >> Sent: Thursday, February 9, 2023 12:17 PM
> >> @@ -223,6 +224,11 @@ struct iommu_iotlb_gather {
> >> /**
> >> * struct iommu_ops - iommu ops and capabilities
> >> * @capable: check capability
> >> + * @hw_info: IOMMU hardware capabilities. The type of the returned
> data
> >> is
> > is it 'info' or 'capability'?
>
> hw_info. IOMMU core does not care about specific content, so it is not
> necessary to define it as capability or anything else.
>
> Perhaps we need to change the comments a bit, say, "IOMMU hardware
> information"?
>

yes, that is probably more consistent.
\
 
 \ /
  Last update: 2023-03-27 00:19    [W:0.066 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site