Messages in this thread | | | Date | Sat, 11 Feb 2023 11:42:44 +0800 | Subject | Re: [PATCH 1/6] iommu: Add new iommu op to get iommu hardware information | From | Baolu Lu <> |
| |
On 2023/2/10 15:28, Tian, Kevin wrote: >> From: Liu, Yi L<yi.l.liu@intel.com> >> Sent: Thursday, February 9, 2023 12:17 PM >> @@ -223,6 +224,11 @@ struct iommu_iotlb_gather { >> /** >> * struct iommu_ops - iommu ops and capabilities >> * @capable: check capability >> + * @hw_info: IOMMU hardware capabilities. The type of the returned data >> is > is it 'info' or 'capability'?
hw_info. IOMMU core does not care about specific content, so it is not necessary to define it as capability or anything else.
Perhaps we need to change the comments a bit, say, "IOMMU hardware information"?
Best regards, baolu
| |