lkml.org 
[lkml]   [2023]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key
From
On 2023. 02. 10. 12:33, Krzysztof Kozlowski wrote:
> On 10/02/2023 00:25, Gergo Koteles wrote:
>> The tri-state-key is a sound profile switch found on the OnePlus 6,
>> Android maps the states to "mute", "vibrate" and "ring". Expose them as
>> ABS_SND_PROFILE events.
>> The previous GPIO numbers were wrong. Update them to the correct
>> ones.
>>
>> Co-developed-by: Caleb Connolly <caleb@connolly.tech>
>> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
>> Signed-off-by: Gergo Koteles <soyer@irl.hu>
>
> Where are other patches? I got only 3/3.
>
Hi Krzysztof,

Sorry, I missed the --thread option for git format-patch.

>> ---
>> .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 39 ++++++++++++++++++-
>> 1 file changed, 38 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> index 64638ea94db7..e45d4fdead82 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -52,6 +52,43 @@ key-vol-up {
>> };
>> };
>>
>> + tri-state-key {
>> + compatible = "gpio-keys";
>> + label = "Tri-state key";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&tri_state_key_default>;
>
> Missing blank line.
>

I'll add it to v3.

>> + state-top {
>
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).
>

I ran dtbs_check with
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/qcom.yaml. It only
shows warnings for msm8996-oneplus3, but not for sdm845-oneplus phones.
Is there anything else I need to check?


...
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dtb: /: qcom,board-id: 'oneOf'
conditional failed, one must be fixed:
[8, 0, 15801, 15, 8, 0, 15801, 16] is too long
From schema: /Documentation/devicetree/bindings/arm/qcom.yaml
...
DTC_CHK arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb
DTC_CHK arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dtb


Thanks,
Gergo

>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2023-03-27 00:17    [W:0.070 / U:23.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site