Messages in this thread | | | Date | Thu, 16 Feb 2023 04:32:00 +0100 | Subject | Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key | From | Gergo Koteles <> |
| |
Hi,
> > > On 11/02/2023 16:40, Pavel Machek wrote: >> Hi! >> >>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >>> @@ -52,6 +52,43 @@ key-vol-up { >>> }; >>> }; >>> >>> + tri-state-key { >>> + compatible = "gpio-keys"; >>> + label = "Tri-state key"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&tri_state_key_default>; >>> + state-top { >>> + label = "Tri-state key top"; >> >> "top/middle" is not too useful. Do we need the label at all? If so, >> should it say "loud/vibrations only/mute"? > > "mute", "vibrate" and "ring" sound good to me. >
OnePlus uses the silent/vibrate/ring, iPhone the silent/ring names. Maybe silent/vibrate/ring are more familiar.
Adding labels can document these modes here. Should we also document these in input-event-codes.h? #define ABS_SND_PROFILE 0x22 /* 0 = silent; 1 = vibrate; 2 = ring */
Thanks, Gergo
> Although it would be nice if users can easily map the physical key > position to the action when viewing the input device or remapping the > key in userspace. > > Do you have any ideas or recommendations on how to do this? >> >> BR, >> Pavel > > -- > Kind Regards, > Caleb >
| |