Messages in this thread | | | Date | Wed, 1 Feb 2023 18:20:22 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v4 05/23] net: phy: add genphy_c45_ethtool_get/set_eee() support |
| |
On Wed, Feb 01, 2023 at 03:58:27PM +0100, Oleksij Rempel wrote: > Add replacement for phy_ethtool_get/set_eee() functions. > > Current phy_ethtool_get/set_eee() implementation is great and it is > possible to make it even better: > - this functionality is for devices implementing parts of IEEE 802.3 > specification beyond Clause 22. The better place for this code is > phy-c45.c > - currently it is able to do read/write operations on PHYs with > different abilities to not existing registers. It is better to > use stored supported_eee abilities to avoid false read/write > operations. > - the eee_active detection will provide wrong results on not supported > link modes. It is better to validate speed/duplex properties against > supported EEE link modes. > - it is able to support only limited amount of link modes. We have more > EEE link modes... > > By refactoring this code I address most of this point except of the last > one. Adding additional EEE link modes will need more work.
phydev->eee_broken_modes in particular is an issue. Anybody with broken 10baseT1L will not be able to work around it currently.
Not that i'm saying this need fixing now.
Andrew
| |