Messages in this thread | | | Date | Wed, 1 Feb 2023 18:28:13 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v4 06/23] net: phy: c22: migrate to genphy_c45_write_eee_adv() |
| |
> + /* This is optional functionality. If not supported, we may get an error > + * which should be ignored. > + */ > + genphy_c45_read_eee_abilities(phydev);
Humm, philosophic discussion. Would it be better for genphy_c45_read_eee_abilities() to silently ignore the error? Errors like -ETIMEDOUT should probably be returned, but -EOPNOTSUPP should be ignored.
Andrew
| |