lkml.org 
[lkml]   [2023]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v4 06/23] net: phy: c22: migrate to genphy_c45_write_eee_adv()
    > +	/* This is optional functionality. If not supported, we may get an error
    > + * which should be ignored.
    > + */
    > + genphy_c45_read_eee_abilities(phydev);

    Humm, philosophic discussion. Would it be better for
    genphy_c45_read_eee_abilities() to silently ignore the error? Errors
    like -ETIMEDOUT should probably be returned, but -EOPNOTSUPP should be
    ignored.

    Andrew

    \
     
     \ /
      Last update: 2023-03-27 00:06    [W:4.138 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site