lkml.org 
[lkml]   [2023]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/12] cifs: Implement splice_read to pass down ITER_BVEC not ITER_PIPE
On Tue, Jan 31, 2023 at 06:28:46PM +0000, David Howells wrote:
> Provide cifs_splice_read() to use a bvec rather than an pipe iterator as
> the latter cannot so easily be split and advanced,

What exactly are the issues? If cifs is running into them others will
as well, so we might better fix them in the infrastructure.

> (1) Bulk-allocate a bunch of pages to carry as much of the requested
> amount of data as possible, but without overrunning the available
> slots in the pipe and add them to an ITER_BVEC.

And that basically makes the splice_read entirely pointless and you
might as well simply not support it.

\
 
 \ /
  Last update: 2023-03-27 00:06    [W:0.092 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site