lkml.org 
[lkml]   [2023]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 05/12] cifs: Add a function to Hash the contents of an iterator
Date
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> > Add a function to push the contents of a BVEC-, KVEC- or XARRAY-type
> > iterator into a symmetric hash algorithm.
>
> There is no such thing as a symmetric hash. You're using shash
> which stands for synchronous hash.

Sorry, you're right.

> In any case, as I said in the previous review this is abusing the
> shash API. Please use ahash instead.

It's already abusing the shash API, this doesn't change that, except where it
gets the data from.

I can have a go at conversion to ahash, but that will have to be a separate
patch set as it isn't trivial. The problem is that the current code just
assumes it can push bits into the hash as it gets them - this is not possible
with ahash.

David

\
 
 \ /
  Last update: 2023-03-27 00:06    [W:0.216 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site