Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH v2] vfio: fix deadlock between group lock and kvm lock | Date | Thu, 2 Feb 2023 04:10:20 +0000 |
| |
> From: Alex Williamson <alex.williamson@redhat.com> > Sent: Thursday, February 2, 2023 7:28 AM > > > > +#ifdef CONFIG_HAVE_KVM > > +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, struct kvm > *kvm) > > I'm tempted to name these vfio_device_get_kvm_safe() and only pass the > vfio_device, where of course we can get the kvm pointer from the group > internally. >
I have a different thought. In the end the cdev series also need the similar safe get/put logic then it's better to keep it in vfio_main.c called by the group/cdev path individually.
| |