lkml.org 
[lkml]   [2023]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] vfio: fix deadlock between group lock and kvm lock
Date
> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, February 2, 2023 11:47 AM
> > > ret = vfio_device_open(device, device->group->iommufd,
> > > device->group->kvm);
> >
> > We're using device->group->kvm outside of kvm_ref_lock here, it should
> > be using device->kvm.
>
> Existing code set device->kvm in the vfio_device_first_open() which is
> called by vfio_device_open(). After above change, seems not necessary
> to pass kvm pointer into the call chain. Isn't it?
>

Looks so.

\
 
 \ /
  Last update: 2023-03-27 00:06    [W:0.174 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site