Messages in this thread | | | Date | Mon, 25 Dec 2023 19:56:24 +0100 | Subject | Re: [PATCH v2 03/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add spi bus | From | Krzysztof Kozlowski <> |
| |
On 25/12/2023 16:13, Petre Rodan wrote: > > hello, > > On Mon, Dec 25, 2023 at 01:59:43PM +0100, Krzysztof Kozlowski wrote: >> On 24/12/2023 15:34, Petre Rodan wrote: >>> Add spi based example. >>> There are many models with different pressure ranges available. The vendor >>> calls them "mpr series". All of them have the identical programming model and >>> @@ -88,6 +88,9 @@ properties: >>> Maximum pressure value the sensor can measure in pascal. >>> To be specified only if honeywell,pressure-triplet is not set. >>> >>> + spi-max-frequency: >>> + maximum: 800000 >> >> So you miss allOf: with $ref to spi props. > > for simplicity's sake and for compatibility with the i2c devices already in use, > this driver does not have distinct 'compatible' properties for the i2c and spi > implementation. > this is why I just defined spi-max-frequency, used it in the spi example, but > not required it. just like in hsc030pa.yaml . > > without a differentiation in the 'compatible' string I don't see how your request > can be implemented.
You cannot have different compatibles. I did not propose it. I wrote nothing about compatible. I wrote about missing $ref in top-level for spi-peripheral-props. Where do you see anything about compatible?
Best regards, Krzysztof
| |