Messages in this thread | | | Date | Mon, 25 Dec 2023 13:59:43 +0100 | Subject | Re: [PATCH v2 03/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add spi bus | From | Krzysztof Kozlowski <> |
| |
On 24/12/2023 15:34, Petre Rodan wrote: > Add spi based example. > > Add spi-max-frequency property required by chip specifications. > > Add additional maintainer. > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > --- > .../iio/pressure/honeywell,mprls0025pa.yaml | 26 +++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > index e4021306d187..430496b047c7 100644 > --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > @@ -8,12 +8,12 @@ title: Honeywell mprls0025pa pressure sensor > > maintainers: > - Andreas Klinger <ak@it-klinger.de> > + - Petre Rodan <petre.rodan@subdimension.ro> > > description: | > Honeywell pressure sensor of model mprls0025pa. > > - This sensor has an I2C and SPI interface. Only the I2C interface is > - implemented. > + This sensor has an I2C and SPI interface. Both are supported.
Instead drop that sentence. Current driver support should not matter for the bindings.
> > There are many models with different pressure ranges available. The vendor > calls them "mpr series". All of them have the identical programming model and > @@ -88,6 +88,9 @@ properties: > Maximum pressure value the sensor can measure in pascal. > To be specified only if honeywell,pressure-triplet is not set. > > + spi-max-frequency: > + maximum: 800000
So you miss allOf: with $ref to spi props.
Best regards, Krzysztof
| |