Messages in this thread | ![/](/images/icornerl.gif) | | From | David Howells <> | Subject | Re: [PATCH] afs: remove redundant overwriting of ret | Date | Thu, 21 Dec 2023 14:10:49 +0000 |
| |
Anastasia Belova <abelova@astralinux.ru> wrote:
> @@ -409,7 +409,6 @@ static int afs_update_cell(struct afs_cell *cell) > if (ret == -ENOMEM) > goto out_wake; > > - ret = -ENOMEM; > vllist = afs_alloc_vlserver_list(0); > if (!vllist) > goto out_wake;
This isn't a sufficient fix.
Yes, you're right, we need to keep ret - but we do need to set -ENOMEM if !vllist if ret does not hold an error.
David
| ![\](/images/icornerr.gif) |